generated from nhs-england-tools/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: RFR transform rules #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification |
stephhou
reviewed
Dec 16, 2025
.../src/Functions/ScreeningValidationService/StaticValidation/Breast_Screening_staticRules.json
Outdated
Show resolved
Hide resolved
.../src/Functions/ScreeningValidationService/StaticValidation/Breast_Screening_staticRules.json
Outdated
Show resolved
Hide resolved
...anager/src/Functions/CohortDistributionServices/TransformDataService/TransformDataService.cs
Show resolved
Hide resolved
...anager/src/Functions/CohortDistributionServices/TransformDataService/TransformDataService.cs
Show resolved
Hide resolved
...anager/src/Functions/CohortDistributionServices/TransformDataService/TransformDataService.cs
Outdated
Show resolved
Hide resolved
...n/CohortManager/src/Functions/Shared/Common/ReasonForRemovalLookup/ReasonForRemovalLookup.cs
Outdated
Show resolved
Hide resolved
Warren-Pitterson
previously approved these changes
Dec 16, 2025
Warren-Pitterson
approved these changes
Dec 17, 2025
stephhou
approved these changes
Dec 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Adds 3 New rules
Added logic to static validation and transfrom to check if a record is a manual add, this is done based on the file name.
For Transfrom this required an update to the TransformDataRequestBody Schema to Include a file name variable.
Fix to wiremock Docker Image to add a user so that its able to start
Added 3 new Stubbed PDS Users for manual Testing
Context
Tickets
Rule 96 - DTOSS-11699
Rule 97 - DTOSS-11758
Rule 98 - DTOSS-11712
These changes are intended to force manually added participants to make it to the Cohort and remove the reason for removal if its on the list of those allowed to be removed form participants. This change is made up of 3 separate rule changes and a code change to determine if a record is a manual add coming from ServiceNow.
To Identify if a record is a manual add directly from Service Now we check the file name is not a parquet file and is instead a SNOW Ticket Number. If this is the case we will run a specific Manual Add Rule WorkFlow.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.