Skip to content

Conversation

@MWClayson-NHS
Copy link
Contributor

@MWClayson-NHS MWClayson-NHS commented Dec 15, 2025

Description

Adds 3 New rules

  • Rule 96 Transform Manual Add RFR removes those on the overrible list
  • Rule 97 Static Validation Checks Manual Add has a Primary Care Provider
  • Rule 98 Static Validation Checks that if the Participant has a Reason For Removal that its Overridable

Added logic to static validation and transfrom to check if a record is a manual add, this is done based on the file name.
For Transfrom this required an update to the TransformDataRequestBody Schema to Include a file name variable.

Fix to wiremock Docker Image to add a user so that its able to start

Added 3 new Stubbed PDS Users for manual Testing

Context

Tickets
Rule 96 - DTOSS-11699
Rule 97 - DTOSS-11758
Rule 98 - DTOSS-11712

These changes are intended to force manually added participants to make it to the Cohort and remove the reason for removal if its on the list of those allowed to be removed form participants. This change is made up of 3 separate rule changes and a code change to determine if a record is a manual add coming from ServiceNow.
To Identify if a record is a manual add directly from Service Now we check the file name is not a parquet file and is instead a SNOW Ticket Number. If this is the case we will run a specific Manual Add Rule WorkFlow.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@MWClayson-NHS MWClayson-NHS changed the title Feat: RFR transform rules feat: RFR transform rules Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Unit Test Results

✔️ Tests 948 / 948 - passed in 65.8s
📝 Coverage 47.24%
📏 4676 / 10177 lines covered 🌿 1147 / 2150 branches covered
🔍 click here for more details

✏️ updated for commit 1afa621

@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 15, 2025
@MWClayson-NHS MWClayson-NHS marked this pull request as ready for review December 16, 2025 10:23
@MWClayson-NHS MWClayson-NHS added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 702639c Dec 17, 2025
9 checks passed
@MWClayson-NHS MWClayson-NHS deleted the feat/rfr-transformRules branch December 17, 2025 14:13
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants